CyberCRI / PeersGraderApp

PeersGrader is an opensource webapp to ease the organisation of peer grading activities by teachers for classes.
https://peergraders.herokuapp.com
MIT License
4 stars 2 forks source link

Confirmation email to the organisator > Use text of step 5 #37

Closed hugolpz closed 6 years ago

hugolpz commented 6 years ago

When sending email to the organisator, use the step 5's content.

Pour l'email de confirmation envoyé au créateur de l'activité. Pour l'instant le contenu de cet email est très pauvre : lien vers l'activité, mot de passe. Il est possible de réutiliser le contenu plus généreux de l'étape 5.

mystermiam commented 6 years ago

Text is done, but in order to put the css and icons, i need to either :

hugolpz commented 6 years ago

With such approach : no additional plug-in needed. :heart: :boom:

1) Via 30mins work, I inlined the core of bulma css code there : http://jsfiddle.net/0yaxcojn/31/ ; the live example is there 2) the variables : activity ID, password are to code 3) this box's content code will pass smoothly and provide the same visual rendering in both our webapp (bulma.css constext), and in emails (no css context)

mystermiam commented 6 years ago

It's still hazardous how the icons are loaded :some are loaded, some are note. I manage to have a mail with all icons one in every three attemps. Did not try on other client than gmail, but since CRI is heavily related on Gmail, i don't know if we should keep icons. It looks kind of dirty when images are not loaded