search

CyberDNS / Lupusec2Mqtt

Lupusec Alarm System to Mqtt
MIT License
11 stars 5 forks source link

Add TemperatureSensor and HumiditySensor #23

Closed scaiandre closed 2 years ago

scaiandre commented 2 years ago

Hi,

I tried to add a sensors for temperature and humidity. Since on Lupusec end this information is provided by the same device, I changed the logic of ConversionService.GetStateProviders and and ConversionService.GetDevices to return IEnumerable.

But beware: It is YEARS since I coded .Net the last time and I very likely made some bad mistakes somewhere, even though in my environment everything is working out fine. Also struturewise you might want to add an additional level of inheritance, but I decided against it.

I hope the code works out for you.

Regards, Andre

CyberDNS commented 2 years ago

Hi Andre,

Thanks for your contribution and sorry for the delayed answer. I will look into your changes as fast as possible.

Best regards, David

CyberDNS commented 2 years ago

I did only small refactoring to your code and integrated it into the Edge version, so you can give it a try in Homeassistant.

Regards, David