CyberDNS
commented
1 year ago Hi @scaiandre and thanks for the pull request.
I was currently working on a new model to make the integration of new devices easier and this includes the problem you are mentioning, I have just now pushed the new model to the master branch.
With the design of the new model you can register 3 different types of "objects":
- StaticValue: This is used to provide static information in the home assistant configuration json that is pushed to MQTT
- Query: This is used to query a state value on Lupusec and to be pushed as state to MQTT (HA)
- Command: This is used to declare a command that is registered on a MQTT topic and that calls something on lupusec (ex. set an the alarm mode, or switch button on power switch)
The devices are now generated by a factory class per device, so that the old conversion class is gone and now every device can handle it's creation on it's own.
Also the poll loop has changed because it is now completely generic, so no special code anymore for alarm panels and switches etc. The class is located in the root folder of the project (MainLoop.cs)
Finally, can I ask you to adapt your code to apply to this new model, I think it should be quite fast and easy.
Best regards, David
scaiandre
The Power Switch also carries a energy meter. Even though energy aggregation could be done on home assistant itself, I'd rather rely on the internal aggregation of the meter itself, as it is more reliable.
In other cases, as the Power Switch carries the data, I think it is useful to have it available.
I feel the return value of ConversionService.GetDevice and ConversionService.GetStateProvider is a little bit cumbersome currently, as I now have added the new SwitchEnergySensor as an additional return value, which is null for most devices. Maybe should rather return a list of thingies of the same interface.
But that would be another type of change...