search

CyberDeck / devise-fido-u2f

A devise module to authenticate additionally with a FIDO U2F hardware token, e.g. a Yubico USB security key.
MIT License
36 stars 4 forks source link

Extends the supported version of Rails and Devise #4

Closed zedtux closed 6 years ago

zedtux commented 6 years ago

This gem is working fine with Rails 4.2 and Devise 3.2.

Also this PR removes the Gemfile.lock -> http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/

zedtux commented 6 years ago

@CyberDeck if you agree with the removal of the Gemfile.lock, you should remove the Hakiri service and remove the bundle scan in codeclimate.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling b59a605d667d00e63665193674c8fbfa079c0252 on Pharmony:tasks/allows-rails-4-and-devise-3 into 9c034714f7fe29389c126c4583e1b1cd2100cb5a on CyberDeck:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 52ae742c8ad2b5a58eb58c7b84b87364126f298e on Pharmony:tasks/allows-rails-4-and-devise-3 into 9c034714f7fe29389c126c4583e1b1cd2100cb5a on CyberDeck:master.

CyberDeck commented 6 years ago

Thank you for your valuable insights.