issues
search
CyberGRX
/
questions-three
Toolkit for developing and executing system-level tests
MIT License
5
stars
2
forks
source link
Remove Unreachable Code: HttpClient
#7
Closed
BrennanAyers
closed
4 years ago
BrennanAyers
commented
4 years ago
Description
[x] Version updated in setup.py
Briefly describe what this PR accomplishes and what the definition of done is.
There was code in the
_request
method of
HttpClient
that was unreachable due to an exception being raised before it
It was evidently a previous implementation that was not removed at the time of change
Type of change
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a migration
Description
Briefly describe what this PR accomplishes and what the definition of done is.
_request
method ofHttpClient
that was unreachable due to an exception being raised before itType of change