QDBordtoshred
commented
3 months ago Make Regular Goomba Do Damage for All Levels
Normal Goomba will not kill you on easy & hard
The original code included a single if statement for Goomba collision on levels normal and imposable.
if (GameEnv.difficulty === "normal | | imposable") {It used ( | | ) which returns the boolean value true if either or both operands is true and returns false otherwise. In other words its an OR operator. Assuming this method worked we could fix the code simply by including the other levels seperated by the same OR operator...
if (GameEnv.difficulty === "normal | | imposable | | hard") {The reason we don't include easy is because Goombas are not supposed to kill you on that difficulty level
Unfortunately after trying such fix I realized this would not work due to the fact that all variables (game levels) are within the same quotations making the the tree separate variables read as one. The fix for such code would be simple...
if (GameEnv.difficulty === "normal" | | "imposable" | | "hard") {With that said the fix I decided to go with was creating 3 separate if statements, one for each level. This allows us to toggle with each level individually as we progress with our changes.
if (this.timer === false) {
this.timer = true;
if (GameEnv.difficulty === "normal") {
this.canvas.style.transition = "transform 0.5s";
this.canvas.style.transform = "rotate(-90deg) translate(-26px, 0%)";
GameEnv.playSound("PlayerDeath");
if (this.isDying == false) {
this.isDying = true;
setTimeout(async() => {
await GameControl.transitionToLevel(GameEnv.levels[GameEnv.levels.indexOf(GameEnv.currentLevel)]);
console.log("level restart")
this.isDying = false;
}, 900);
}
}
if (GameEnv.difficulty === "hard") {
this.canvas.style.transition = "transform 0.5s";
this.canvas.style.transform = "rotate(-90deg) translate(-26px, 0%)";
GameEnv.playSound("PlayerDeath");
if (this.isDying == false) {
this.isDying = true;
setTimeout(async() => {
await GameControl.transitionToLevel(GameEnv.levels[GameEnv.levels.indexOf(GameEnv.currentLevel)]);
console.log("level restart")
this.isDying = false;
}, 900);
}
}
if (GameEnv.difficulty === "impossible") {
this.canvas.style.transition = "transform 0.5s";
this.canvas.style.transform = "rotate(-90deg) translate(-26px, 0%)";
GameEnv.playSound("PlayerDeath");
if (this.isDying == false) {
this.isDying = true;
setTimeout(async() => {
await GameControl.transitionToLevel(GameEnv.levels[GameEnv.levels.indexOf(GameEnv.currentLevel)]);
console.log("level restart")
this.isDying = false;
}, 900);
}
}
else if (GameEnv.difficulty === "easy") {
this.x += 10;
}
}
}
LiliWuu
TianbinLiu
Rapid Left and Right Jittering Movement Fix (with too many enemies on screen)
Sometimes the Goombas will start jittering in place upon colliding with one another or the obstacles. The jittering movement may be caused by the randomness of the Goomba collisions, so probably change this part of the Goomba.js code:
(I'm still not sure how to fix this issue but maybe we can have collision action happen only between the Goombas and the obstacles and not between Goombas to reduce the possible randomness of the collision movements (although this would make the enemy movement less interesting))
FlyingGoomba Not Doing Damage Fix
The player can essentially pass through the FlyingGoomba without it doing any damage to the player. This could be an error within the collision action part of the FlyingGoomba.js code and could be a result of it missing parts of the animation/action that would happen following collision detection with player. Comparing it to the Goomba.js collision code:
and the FlyingGoomba.js collision code:
it seems to be missing the transforming animation (but this could be on purpose. Also not sure if this solves the collision detection part of the code though because it could just be a bug resulting from the FlyingGoomba animation. Maybe instead create the animation code after implementing Goomba doing damage code <- according to Xavier)