dev_struct_finding : typo + bug

CyberPoint / libpgm

A library for creating and using probabilistic graphical models

BSD 3-Clause "New" or "Revised" License

76 stars 44 forks source link

dev_struct_finding : typo + bug #10

Open tingyuansen opened 9 years ago

tingyuansen commented 9 years ago

Hi there,

I came across another bug in the dev_struct_finding branch. When libpgm calculates the likelihood, it calls norm(loc=mean, scale=variance). It should be scale=np.sqrt(variance).

Thanks.

Cheers, Yuan-Sen

cccabot commented 9 years ago

Good catch -- just pushed that fix into dev_struct_finding. We will merge into master once we look at the other outstanding issues.