search

CyberPunkMetalHead / Binance-News-Sentiment-Bot

This is a fully functioning Binance trading bot that takes into account the news sentiment for the top 100 crypto feeds. If you like this project consider donating though the Brave browser to allow me to continuously improve the script.
MIT License
1.57k stars 290 forks source link

Fixed many parsing errors that occurred due to small timeout, also some code beautifying #22

Closed idanpl closed 3 years ago

idanpl commented 3 years ago

In the commit:

  1. timeout was changed from 7 to 60. Problem was that many articles could not be fetched in this time (especially when you have mutlitasking, and I believe that the timeout is starting when the task is created and before the actual request is made // observation....I'm not a python ninja).
  2. find_lot_size method is redundant, so I actually removed it.
  3. some comment update.
CyberPunkMetalHead commented 3 years ago

I have not been able to replicate your issue, can you temporarily remove the try: and except: conditions and check what error is your code returning?

CyberPunkMetalHead commented 3 years ago

Also, please elaborate on why find lot size is redundant

idanpl commented 3 years ago

With all the changes made after the pull request, all that remains is the timeout. Will simply close this pull request.