Sell order - Githubissues

CyberPunkMetalHead / Binance-News-Sentiment-Bot

This is a fully functioning Binance trading bot that takes into account the news sentiment for the top 100 crypto feeds. If you like this project consider donating though the Brave browser to allow me to continuously improve the script.

MIT License

1.57k stars 290 forks source link

Sell order #6

Closed koraycaglar closed 3 years ago

koraycaglar commented 3 years ago

Sell function added.
The bot sells %99.5 of the coins it bought in order to avoid exceptions
"coins_in_hand" dictionary stores the amount of coins the bot bought and currently holding.
nltk.download('vader_lexicon') added
Selling on BCH/USDT pairing gives this exception for some reason (I can't tell why): BinanceAPIException: APIError(code=-1121): Invalid symbol.
When buying/selling this exception sometimes happens: BinanceAPIException: APIError(code=-1013): Filter failure: LOT_SIZE

Feel free to change/copy anything you see fit.

koraycaglar commented 3 years ago

That's fine! Have a great day :)

CyberPunkMetalHead commented 3 years ago

You too! Your contribution and the latest version of the code now lives in a new branch at: https://github.com/CyberPunkMetalHead/Binance-News-Sentiment-Bot/tree/Binance-News-Sentiment-Bot-Plus-Sell

During my testing it seems that the loop inside the buy function doesn't iterate through all the coins in compound sentiment, seems to only go through 1 item. I'm looking into it, but if you're still interested to contribute, it would be great if you can help out with that :)

koraycaglar commented 3 years ago

Yeah I just saw it on Issues and answered it. Let me know how it turns out :)

CyberPunkMetalHead commented 3 years ago

Amazing, thank you :)