search

CyberPunkMetalHead / Binance-volatility-trading-bot

This is a fully functioning Binance trading bot that measures the volatility of every coin on Binance and places trades with the highest gaining coins If you like this project consider donating though the Brave browser to allow me to continuously improve the script.
MIT License
3.41k stars 777 forks source link

Adds a script that sells the remaining coins and deletes coins_bought file #110

Closed Tarantinooo closed 3 years ago

Geeks-Sid commented 3 years ago

Is this necessary? Shouldn't the trades be saved?

Tarantinooo commented 3 years ago

Is this necessary? Shouldn't the trades be saved?

This is only for after you stop the bot, and there are still coins left in your portfolio that the bot didn't sell yet. Instead of going to Binance and doing it manually, this script sells all the coins that are still left on the coins_bought list

Tarantinooo commented 3 years ago

Is this necessary? Shouldn't the trades be saved?

Also the trades are saved in another txt file, trades.txt

ShogunMan commented 3 years ago

Is this necessary? Shouldn't the trades be saved?

Also the trades are saved in another txt file, trades.txt

But you are not writing the trades from this module into trades.txt, messing up the integrity of the file. You will have coins that are bough, but never sold, and not know at what price or profit they were sold.

Tarantinooo commented 3 years ago

Is this necessary? Shouldn't the trades be saved?

Also the trades are saved in another txt file, trades.txt

But you are not writing the trades from this module into trades.txt, messing up the integrity of the file. You will have coins that are bough, but never sold, and not know at what price or profit they were sold.

That's a good one. Didn't think of that. I will try to write something for that so that it still calculates it for the trades.txt file. Can't promise anything as I'm a beginner coder