This is a fully functioning Binance trading bot that measures the volatility of every coin on Binance and places trades with the highest gaining coins If you like this project consider donating though the Brave browser to allow me to continuously improve the script.
Validation must be ran in both prod and test (see TEST_MODE)
Original issue replicated below in test and prod.
Testing condition - Already holding 3 coins. There need to be qualifying signals on both volatile & external list in same loop.
Desired outcome: Bot should only buy 1 coin.
Actual outcome: Bot buys 2 coins.
The bot was then tested with the fix in the same situation and it bought only 1 coin:
In your own words, please share how this makes the codebase better.
This will handle instances where the bot is buying more than the MAX_COINS set in the config file
PRs that wont be accepted
What are you addressing in this PR
How have you tested this PR
Validation must be ran in both
prodandtest(see TEST_MODE)Original issue replicated below in test and prod. Testing condition - Already holding 3 coins. There need to be qualifying signals on both volatile & external list in same loop. Desired outcome: Bot should only buy 1 coin. Actual outcome: Bot buys 2 coins.
The bot was then tested with the fix in the same situation and it bought only 1 coin:
In your own words, please share how this makes the codebase better.