search

CyberPunkMetalHead / Binance-volatility-trading-bot

This is a fully functioning Binance trading bot that measures the volatility of every coin on Binance and places trades with the highest gaining coins If you like this project consider donating though the Brave browser to allow me to continuously improve the script.
MIT License
3.39k stars 775 forks source link

Move configuration items to JSON file #2

Closed andrewsauter-nbcuni closed 3 years ago

andrewsauter-nbcuni commented 3 years ago

https://github.com/CyberPunkMetalHead/Binance-volatility-trading-bot/blob/0343a3d9329a40eb19ae9e4c25bad0021b9fcbcc/Binance%20Detect%20Moonings.py#L30

Since this will largely be used by people without coding experience, I would put all configuration items in a separate JSON config file. This will make it easier to read and less confusing for people to configure and setup properly.

riolcrt commented 3 years ago

I think it's more dangerous do it that way, because with no coding experience your API key could end online by accident if it's written in a file.

andrewsauter-nbcuni commented 3 years ago

@riolcrt I'm not following, it's already in a file. I'm suggesting he take it out of the main file where the code is. Literally no difference in functionality, just less confusing for people to configure.

getsec commented 3 years ago

Keys now in creds.yml creds.yml is gitignored.