CyberPunkMetalHead / Binance-volatility-trading-bot

This is a fully functioning Binance trading bot that measures the volatility of every coin on Binance and places trades with the highest gaining coins If you like this project consider donating though the Brave browser to allow me to continuously improve the script.
MIT License
3.39k stars 774 forks source link

Market vs limit sell, recommended code change #231

Open birk151 opened 1 year ago

birk151 commented 1 year ago

Cannot trade profitably with low volume coins. Market sell orders trigger at TP, but will often sell for less then the buy price due to low volume.

Suggest changing sell parameter to:

            if not TEST_MODE:
                sell_coins_limit = client.create_order(
                    symbol = coin,
                    side = 'SELL',
                    type = 'LIMIT',
                    price = coins_bought[coin]['take_profit']
                    timeinForce = 'GTC',
                    quantity = coins_bought[coin]['volume']

                )

This of course eliminates the trailing profit function but will guarantee the sale price to be the TP as intended.