transform to modular design

[Davidobot]

"modular design" =/= factoring out every function into a different python file

I think this makes the code significantly less readable, especially given the very linear nature of some of the function calls, eg buy -> convert_volume -> wait_for_price -> get_price

If I didn't know the codebase then jumping through all these hoops of looking into different files would make me rather quite confused.

If I were to refactor:

• I'd make updating the portfolio more streamlined
• move helper functions (like writing to log) to a separate file
• move processing the config into a helper function
• keep the buying + selling logic in main file as-is

[O-Mutt]

I'm gonna echo a little bit from ☝️

This is less of a modular design and more of a function split.

I would love to see a portfolio.py that handles all the CRUD of the portfolio, binance_service that handles interactions (and error handling) of external calls to the service. And break it down into responsibility rather than files.

While this "split" may help PRs a little easier to handle I don't think it moves us toward the goal of building a more robust, understandable, and extensible codebase

[getsec]

@O-Mutt and @Davidobot are right. Im gonna take a stab at this.

[CyberPunkMetalHead]

Fair enough. In that case I will close this request and merge @Davidobot ’s PR next. My only comment on your PR is that we could use a bit more logging when coins are not being bought, I thought the code was broken when it wouldn’t print anything for minutes at a time.

[CyberPunkMetalHead]

@getsec might wanna base it off David’s pr to avoid conflicts

[getsec]

Fair enough. In that case I will close this request and merge @Davidobot ’s PR next. My only comment on your PR is that we could use a bit more logging when coins are not being bought, I thought the code was broken when it wouldn’t print anything for minutes at a time.

I think this is good. Once his PR is out we can expand.