Various Updates / Fixes

CyberPunkMetalHead / binance-trading-bot-new-coins

This Binance trading bot detects new coins as soon as they are listed on the Binance exchange and automatically places sell and buy orders. It comes with trailing stop loss and other features. If you like this project please consider donating via Brave.

MIT License

1.46k stars 269 forks source link

Various Updates / Fixes #13

Closed cdalton713 closed 2 years ago

cdalton713 commented 2 years ago

Changes: I have not had a new coin populate yet, so I have not fully tested all of these changes.

added simple tests
'frequency' in 'main' was not used, so the loop was running continuously without taking this config param into question. Added sleep function to slow loop down appropriately. Changed frequency format from minutes to SECONDS
renamed get_price in trade_client.py to avoid confusion
test mode for purchases now gets the current price of the coin and returns a response with the same format as a real request.
Added typings to functions
Refactored folders, cleaned up formatting/typos
added logging and periodic update on program status message
updated gitignore

cinderblockgames commented 2 years ago

'frequency' in 'main' was not used, so the loop was running continuously without taking this config param into question. Added sleep function to slow loop down appropriately. Changed frequency format from minutes to SECONDS

That explains why I kept getting banned while testing! I'll pull the changes and see if I can move forward. Thanks!

CyberPunkMetalHead commented 2 years ago

Thanks for this, are you able to resolve the conflicts in main.py? There's been an update to the get_new_coins function that improves the execution speed.

Are you able to run a speed benchmark on your version? Current version loops every 0.2s

cdalton713 commented 2 years ago

I fixed those conflicts based on your latest version. A few notes:

for generate_coin_seen_dict you used defaultdict(bool). I couldn't figure out why so I made it a normal dict. If it was like that for a reason I missed let me know!
that loop speed you mentioned will be largely dependant on the machine it's running on, and since people are getting API blocked with low-frequency values right now anyways I don't think it's a huge bottleneck. With that said, I may try making some of this async and OO and see where that gets me (but I'll save that for another pull request). I primarily use FTX and am interested in porting this idea to that exchange as well, so an OO refactor would help with that.