search

CyberPunkMetalHead / binance-trading-bot-new-coins

This Binance trading bot detects new coins as soon as they are listed on the Binance exchange and automatically places sell and buy orders. It comes with trailing stop loss and other features. If you like this project please consider donating via Brave.
MIT License
1.46k stars 268 forks source link

QUESTION : SELL and BUY swapped? #62

Open 3ntr0phy opened 3 years ago

3ntr0phy commented 3 years ago

Probably a stupid question but in the first commit the BUY block was in the end and now they are swapped. Did the logic changed and the comments are old or am I missing something?

3ntr0phy commented 3 years ago

I guess it is because you changed from SPOT to MARGIN, any specific reason to that?

CyberPunkMetalHead commented 3 years ago

It was meant to work as a margin sell but what’s not possible due to several factors, so I will have to revert back to SPOT but in this branch.

If you want to find out how the sell strategy works see it explained here: https://youtu.be/qqXQgwuFI8s

Also, the sell logic has now been moved to its own branch so make sure to check that one out here: https://github.com/CyberPunkMetalHead/binance-trading-bot-new-coins/tree/buy_outside_binance

3ntr0phy commented 3 years ago

Okay so basically it should be worth reverting back to the previous code - SPOT - for buying and sell right? Because even in the new branch you shared the order is still margin