search

CyberPunkMetalHead / binance-trading-bot-new-coins

This Binance trading bot detects new coins as soon as they are listed on the Binance exchange and automatically places sell and buy orders. It comes with trailing stop loss and other features. If you like this project please consider donating via Brave.
MIT License
1.46k stars 268 forks source link

Important params unused #77

Closed oularrea closed 2 weeks ago

oularrea commented 2 years ago

Reviewing the code due to an error when executing the bog of "('Connection aborted.', ConnectionResetError (104, 'Connection reset by peer'))" and increasing the same error kept happening, I started to review the code and I see that the parameter frequency = config ['TRADE_OPTIONS'] ['RUN_EVERY'] is not used in any part of the code, that's why this error happens. you could review it?

I have also checked that the parameter coin_sl = order [coin] ['sl']is not used either, but I'm not sure how important it is to close trades at a loss.

webdesign7 commented 2 years ago

I also noticed that, any ideas @CyberPunkMetalHead ?