search

CyberPunkMetalHead / gateio-crypto-trading-bot-binance-announcements-new-coins

This is a crypto trading bot that scans the Binance Annoucements page for new coins, and places trades on Gateio
MIT License
1.21k stars 303 forks source link

Add discord notifications #107

Open digital-pedrocosta opened 2 years ago

digital-pedrocosta commented 2 years ago

New feature to add Discord notifications (same way as the already implemented msgs to Telegram) The user needs to provide the Discord's webhook url

Linus045 commented 2 years ago

I think at this point we should refactor this somehow. I tried to do some changes in #103 but if there are gonna be more and more notification channels later it will get annoying to provide the extras to the logging functions. I think a general 'channel' param should be added and the forwarding to discord/telegram/whatever should be handled on the logger level, so instead of logger.info("new-coin-bot online", extra={'TELEGRAM': 'STARTUP', 'DISCORD': 'STARTUP'}) its just logger.info("new-coin-bot online", channel='STARTUP')

Linus045 commented 2 years ago

also the package needs to be added to the requirements.txt, otherwise people will get errors when trying to use the bot.

nitad54448 commented 2 years ago

To be honest, in my opinion all Discord/Telegram and so on are minor, non-essential, developments. The main problem for this bot is that it buys close to the top , i.e. too late (the last 4 buys in my case where "buy high-sell low". For the last case, the bot found it 3 seconds after the announcement and still it was too late. Looking at price charts, it seems that the rders are launched at least one minute before the actual listing... typically at HH.59 min you can see the price going up. It might be just someone has an "intuition", if you catch my drift or a friend of a friend that knows in advance about the listing and buys the coin in the minute before the listing. If this is the case it looks like inside-trading. So, unless we find a way to buy in time, it does not matter that you have a telegram bot to tell you that you are going to loose money...because no one is going to use the bot. So, is there anyone that got any profit recently ? If so, can you post the log and you config ? Thanks

Linus045 commented 2 years ago

@nitad54448 I understand your problems with the bot, but please open a separate issue for that. The points you mentioned are unrelated to this specific Pull-Request and therefore don't belong here.

The notifications for discord/telegram are just a feature the bot offers and altough they are minor, they still add a nice way to notify the user when a new coin gets released/etc.. Optimizing the buy/sell behaviour of the bot might be "more important" but is also very difficult task because of all the different factors that play into it.

nitad54448 commented 2 years ago

@nitad54448 I understand your problems with the bot, but please open a separate issue for that. The points you mentioned are unrelated to this specific Pull-Request and therefore don't belong here.

The notifications for discord/telegram are just a feature the bot offers and altough they are minor, they still add a nice way to notify the user when a new coin gets released/etc.. Optimizing the buy/sell behaviour of the bot might be "more important" but is also very difficult task because of all the different factors that play into it.

Hi, OK, I am a noob with Github not sure were to put my comment. I still believe that the issue I raise here is related with this pull-request : my point is that there is no need of a notification if the bot is useless. I have no particular "problem with the bot" other than the problem that the buy is too late. In my opinion the effort should be directed to solving this problem of buying at the peak, otherwise I see no use of it. N

Linus045 commented 2 years ago

Please create a new issue here to further discuss your problem: https://github.com/CyberPunkMetalHead/gateio-crypto-trading-bot-binance-announcements-new-coins/issues/new

nitad54448 commented 2 years ago

Please create a new issue here to further discuss your problem: https://github.com/CyberPunkMetalHead/gateio-crypto-trading-bot-binance-announcements-new-coins/issues/new

I copied my message to the "issues" for discussion but I don't understand why do you say "your problem". It Is not only my problem but also "your problem". Have you got the bot running with a profit ?