CyberPunkMetalHead / gateio-crypto-trading-bot-binance-announcements-new-coins

This is a crypto trading bot that scans the Binance Annoucements page for new coins, and places trades on Gateio
MIT License
1.22k stars 302 forks source link

fixed out of idx #11

Closed kazyka closed 3 years ago

kazyka commented 3 years ago

I can also add to ignore exclusions = ['Futures', 'Margin', 'adds', 'Adds'] But right now it should look after matches in brackets with regex '\(([^)]+)' i.e. Binance will add () it will extract

CyberPunkMetalHead commented 3 years ago

Can you add the exclusion logic in? These shouldn't be picked up: image

PRamia commented 3 years ago

why don't you just search for first appearance of "Binance Will List" string and scrap its coin symbol?

kazyka commented 3 years ago

why don't you just search for first appearance of "Binance Will List" string and scrap its coin symbol?

This could also be done. But we have to be sure that they always type it as that.

PRamia commented 3 years ago

Checking the historical you can make sure about that.

new_coin = '' if "Binance Will List " in latest_announcement : open_parent_pos = latest_announcement('(') close_parent_pos = latest_announcement(')') new_coin = latest_announcement[open_parent_pos+1:close_parent_pos] return new_coin else: return new_coin

kazyka commented 3 years ago

Can you add the exclusion logic in? These shouldn't be picked up: image

It should be fixed now