Closed iamtodor closed 2 years ago
Creds to @prastiwari with his PR https://github.com/CyberPunkMetalHead/gateio-crypto-trading-bot-binance-announcements-new-coins/pull/38
PR #38 shall be closed without merging once this one will be merged cc @DominicFrei
@DominicFrei please take a look at the logging improvement that I've done. I reckon it's great to have explicit stop
along with start
.
Please let me know what do you think?
@DominicFrei please take a look at the logging improvement that I've done. I reckon it's great to have explicit
stop
along withstart
. Please let me know what do you think?
It doesn't fit the initial intent of the PR anymore and was added after I approved but since it's just a couple lines of code I don't see an issue with that. Fine from my side. :+1:
@DominicFrei Thank you. Yeah, I do agree it's not aligned with the initial purpose
Looks like there's a small conflict that needs to be resolved here and GitHub doesn't seem to allow me to resolve upon merging. Happy to merge this once resolved, thanks!
@CyberPunkMetalHead resolved :)
logging improvement