search

CyberPunkMetalHead / gateio-crypto-trading-bot-binance-announcements-new-coins

This is a crypto trading bot that scans the Binance Annoucements page for new coins, and places trades on Gateio
MIT License
1.21k stars 303 forks source link

Fixed concatenation errors #116

Closed iamtodor closed 2 years ago

iamtodor commented 2 years ago

logging improvement

iamtodor commented 2 years ago

Creds to @prastiwari with his PR https://github.com/CyberPunkMetalHead/gateio-crypto-trading-bot-binance-announcements-new-coins/pull/38

iamtodor commented 2 years ago

PR #38 shall be closed without merging once this one will be merged cc @DominicFrei

iamtodor commented 2 years ago

@DominicFrei please take a look at the logging improvement that I've done. I reckon it's great to have explicit stop along with start. Please let me know what do you think?

DominicFrei commented 2 years ago

@DominicFrei please take a look at the logging improvement that I've done. I reckon it's great to have explicit stop along with start. Please let me know what do you think?

It doesn't fit the initial intent of the PR anymore and was added after I approved but since it's just a couple lines of code I don't see an issue with that. Fine from my side. :+1:

iamtodor commented 2 years ago

@DominicFrei Thank you. Yeah, I do agree it's not aligned with the initial purpose

CyberPunkMetalHead commented 2 years ago

Looks like there's a small conflict that needs to be resolved here and GitHub doesn't seem to allow me to resolve upon merging. Happy to merge this once resolved, thanks!

iamtodor commented 2 years ago

@CyberPunkMetalHead resolved :)