search

CyberPunkMetalHead / gateio-crypto-trading-bot-binance-announcements-new-coins

This is a crypto trading bot that scans the Binance Annoucements page for new coins, and places trades on Gateio
MIT License
1.21k stars 302 forks source link

Rotating proxy functionality #139

Closed andreademasi closed 2 years ago

andreademasi commented 2 years ago

This PR addresses issues regarding rate limiting by using a socks5 rotating proxy derived from a list of proxies fetched from proxyscan.io. May fix #137 and #115 Main issue is proxy quality, some of them are slow or not working.

TODO:

Linus045 commented 2 years ago

You somehow changed the line-endings think, which marked the whole file as changed, can you fix that, so only your actual changes are marked.

andreademasi commented 2 years ago

@Linus045 Fixed

andreademasi commented 2 years ago

I'm thinking it might be useful to filter proxies to countries close to japan (where Binance's servers are located) like China, Thailand, Singapore, South Korea, Hong Kong, and of course Japan. This can be easily achieved in the API call: https://www.proxyscan.io/api/proxy?last_check=180&country=cn,th,sg,kr,hk,jp&limit=20&type=socks5&format=txt&ping=1000

@Linus045 what are your thoughts on this?

Linus045 commented 2 years ago

I'm thinking it might be useful to filter proxies to countries close to japan (where Binance's servers are located) like China, Thailand, Singapore, South Korea, Hong Kong, and of course Japan. This can be easily achieved in the API call: https://www.proxyscan.io/api/proxy?last_check=180&country=cn,th,sg,kr,hk,jp&limit=20&type=socks5&format=txt&ping=1000

@Linus045 what are your thoughts on this?

I agree, but I think this should be done in a new PR. It should be an option in the options.yml similar to the other stuff I mentioned above.

Linus045 commented 2 years ago

This looks good to me. Small problems and the other stuff discussed in the comments will be fixed/integrated in new PRs.