CyberPunkMetalHead / gateio-crypto-trading-bot-binance-announcements-new-coins

This is a crypto trading bot that scans the Binance Annoucements page for new coins, and places trades on Gateio
MIT License
1.21k stars 303 forks source link

feature/logging/display-fetch-message-once-a-minute #41

Closed busyuqboy closed 2 years ago

busyuqboy commented 2 years ago

feature/logging/display-fetch-message-once-a-minute

Overview

The app fetches possible gate.io announcements every 3 seconds. Don't log a message until one minute has passed. This helps to not bloat the log file with too many of the same Checking for coin announcements every 3 seconds (in a separate thread) message.

smuu commented 2 years ago

In my opinion, logging should happen every time if the event occurs. We could consider moving some outputs to debug logging to decrease the size of the log and only log to info if something 'interesting' as a trade happens.

nitad54448 commented 2 years ago

In my opinion, logging should happen every time if the event occurs. We could consider moving some outputs to debug logging to decrease the size of the log and only log to info if something 'interesting' as a trade happens.

I agree with this.

CyberPunkMetalHead commented 2 years ago

I agree this should log with every iteration