search

CyberPunkMetalHead / gateio-crypto-trading-bot-binance-announcements-new-coins

This is a crypto trading bot that scans the Binance Annoucements page for new coins, and places trades on Gateio
MIT License
1.21k stars 303 forks source link

move regular logging to debug #44

Open smuu opened 2 years ago

smuu commented 2 years ago

As the log is 'spammed' by two regular tasks, the log gets big pretty fast. Also, as an end user, I expect that the basic future works and not get logged in info but in debug. This is a proposal as an alternative to the approach in #41.

Should we consider alternate the logging behavior on any other parts of the application?

DominicFrei commented 2 years ago

Another good idea is https://github.com/CyberPunkMetalHead/gateio-crypto-trading-bot-binance-announcements-new-coins/pull/74. I'd suggest leaving it on info since that's the best fit. It's not really a debug statement.

DominicFrei commented 2 years ago

Another good idea is #74. I'd suggest leaving it on info since that's the best fit. It's not really a debug statement.

After thinking about that again, I stand by the idea of it not being debug but I guess it's also not info. It's just a heartbeat that clutters the log. Maybe remove it altogether and only log problems and actual announcements and deal with the heartbeat differently? We had a discussion about that in Discord that I thought was really productive.

Linus045 commented 2 years ago

I agree, I would remove it altogether and prioritize error logging.