Fix announcement_coin=False issue AND prevent API caching

CyberPunkMetalHead / gateio-crypto-trading-bot-binance-announcements-new-coins

This is a crypto trading bot that scans the Binance Annoucements page for new coins, and places trades on Gateio

MIT License

1.21k stars 303 forks source link

Fix announcement_coin=False issue AND prevent API caching #53

Closed Jrjy3 closed 2 years ago

CyberPunkMetalHead commented 2 years ago

Maybe I'm missing something but you're randomising the page number. As far as I'm aware page number should always be 1.

akrz commented 2 years ago

@CyberPunkMetalHead It's hardcoded as "pageNo=1"

CyberPunkMetalHead commented 2 years ago

My bad, seems I can't read! Looks good to me. Happy to merge if this has run locally to ensure there are no errors thrown.

Jrjy3 commented 2 years ago

My bad, seems I can't read! Looks good to me. Happy to merge if this has run locally to ensure there are no errors thrown.

I updated the variable name to be more clear. I've been running this version without issues and so has @cryptmjt as well as a few other people in the discord server. Seems like it's running without issues to me.