search

CyberPunkMetalHead / gateio-crypto-trading-bot-binance-announcements-new-coins

This is a crypto trading bot that scans the Binance Annoucements page for new coins, and places trades on Gateio
MIT License
1.21k stars 303 forks source link

logs are now placed in logging directory and split into daily files #71

Closed flumi3 closed 2 years ago

flumi3 commented 2 years ago

Since the size of the log file can be MASSIVE very quickly, it would be better to split them into several files and place them into a seperate folder.

With this change, log files are now split into daily files which means that there will be a log file for every day beginning on midnight. Also, the logs will now be placed into a seperate folder called "logs" with a date appendix.

alecsiemerink commented 2 years ago

This would be great. Also for when using this as a container, for persistence reasons.

Jrjy3 commented 2 years ago

I was planning to add a feature like this at some point in the future! You beat me to it. I'll test this out later today.

Jrjy3 commented 2 years ago

Accidentally merged while trying to merge with my fork for testing. Whoops...

Jrjy3 commented 2 years ago

@flumi3 Could you please resubmit this pull request? Github doesn't allow you to re-open a pull request after it has been merged.

flumi3 commented 2 years ago

Sure! I'll do it as soon as I'm at home again

Jrjy3 commented 2 years ago

@flumi3 Thanks! Sorry about the accidental merge and revert. I'm testing this PR now and it seems like it's working for me. After it rotates the log files at midnight tonight, I'll let Cryptomaton know that I vote for it to be merged!