Closed Damantino closed 2 years ago
There is a similar PR. Maybe you guys wanna work together on one solution that includes all ideas? I do see merge conflicts there. :)
I've tried to work on this but I see no issues on my local forked repository, help, how could I solve this conflicts?!
I use Unraid, so this would be a step closer (docker) to have this supported on Unraid as docker!
@DominicFrei what should be done in this PR in order to be merged?
@DominicFrei what should be done in this PR in order to be merged?
As far as I can see, addressing the comments and fixing the conflicts and we're good to go. :+1: Also, if reactions come in too slow, feel free to just tag people in Discord. It seems to be the main platform, not the PRs (unfortunately) ...
@DominicFrei got it. Yeah, for sure I can take a handover for this PR, no problem. Would you mind sharing your discord name? I'd like to discuss some things there then
@DominicFrei got it. Yeah, for sure I can take a handover for this PR, no problem. Would you mind sharing your discord name? I'd like to discuss some things there then
The Discord for this bot is https://discord.gg/RVCvyyDH
My Discord name is: dodoTV42#0383
Note that PMs are restricted to people that I share any server with.
Should be good to go now, could you please take a look? @DominicFrei @iamtodor
@Damantino thank you for such a prompt implementation! LGTM 👍
Thanks all! Looks good to me. Merging now.
The current version of the app is not so good for Docker running. Docker engine supposes providing app parameters through ENV variables. You should consider updating the app with such an opportunity
Restructured folders to put all code under src to make it easier to dockerize
Add dockerfile