CyberPunkMetalHead / gateio-crypto-trading-bot-binance-announcements-new-coins

This is a crypto trading bot that scans the Binance Annoucements page for new coins, and places trades on Gateio
MIT License
1.21k stars 303 forks source link

feat: add python alpine dockerfile and restructure folders #76

Closed Damantino closed 2 years ago

Damantino commented 2 years ago
DominicFrei commented 2 years ago

There is a similar PR. Maybe you guys wanna work together on one solution that includes all ideas? I do see merge conflicts there. :)

Damantino commented 2 years ago

I've tried to work on this but I see no issues on my local forked repository, help, how could I solve this conflicts?!

rcamarda390 commented 2 years ago

I use Unraid, so this would be a step closer (docker) to have this supported on Unraid as docker!

iamtodor commented 2 years ago

@DominicFrei what should be done in this PR in order to be merged?

DominicFrei commented 2 years ago

@DominicFrei what should be done in this PR in order to be merged?

As far as I can see, addressing the comments and fixing the conflicts and we're good to go. :+1: Also, if reactions come in too slow, feel free to just tag people in Discord. It seems to be the main platform, not the PRs (unfortunately) ...

iamtodor commented 2 years ago

@DominicFrei got it. Yeah, for sure I can take a handover for this PR, no problem. Would you mind sharing your discord name? I'd like to discuss some things there then

DominicFrei commented 2 years ago

@DominicFrei got it. Yeah, for sure I can take a handover for this PR, no problem. Would you mind sharing your discord name? I'd like to discuss some things there then

The Discord for this bot is https://discord.gg/RVCvyyDH My Discord name is: dodoTV42#0383 Note that PMs are restricted to people that I share any server with.

Damantino commented 2 years ago

Should be good to go now, could you please take a look? @DominicFrei @iamtodor

iamtodor commented 2 years ago

@Damantino thank you for such a prompt implementation! LGTM 👍

CyberPunkMetalHead commented 2 years ago

Thanks all! Looks good to me. Merging now.

warren-ru commented 2 years ago

The current version of the app is not so good for Docker running. Docker engine supposes providing app parameters through ENV variables. You should consider updating the app with such an opportunity