There is an edge case issue where two orders trying to opperate buy/sells at the same time will create an invalid order. This will be an issue if a second announcement is made while the first announcement has completed and turned into an active order (in order.json).
The second order will create the invalid order issue only when it comes back as cancelled status. This is the edge case. If the order comes back closed the operation isn't impacted. This is due to the order dictionary being "cleared" (all orders) instead of removing just the key (coin) that needs to be re-purchased.
The issue is known by the following log output:
Order is initialized but not ready. Continuing.
Multiple session support
The session.json file is used to help with partially filled/multiple orders per coin and to help sum the total fees for all orders produced. This is critical for the sale order to be able to sell 100% of the amount that the bot purchased.
There is an initialization of the session variable that is killing the historical/saved values. This can cause an active order to not be able to sell correctly due to the summed fees being wiped.
These two issues were introduced by code introduced by PR #62
Overview
There is an edge case issue where two orders trying to opperate buy/sells at the same time will create an invalid order. This will be an issue if a second announcement is made while the first announcement has completed and turned into an active order (in order.json).
The second order will create the invalid order issue only when it comes back as
cancelled
status. This is the edge case. If the order comes backclosed
the operation isn't impacted. This is due to the order dictionary being "cleared" (all orders) instead of removing just the key (coin) that needs to be re-purchased.The issue is known by the following log output:
Order is initialized but not ready. Continuing.
The
session.json
file is used to help with partially filled/multiple orders per coin and to help sum the total fees for all orders produced. This is critical for the sale order to be able to sell 100% of the amount that the bot purchased.There is an initialization of the session variable that is killing the historical/saved values. This can cause an active order to not be able to sell correctly due to the summed fees being wiped.
These two issues were introduced by code introduced by PR #62