search

CyberRadio / gr-cyberradio

MIT License
5 stars 4 forks source link

JsonCPP deprecation warning #5

Closed jwmelto closed 2 years ago

jwmelto commented 3 years ago

Building libcyberradio,

/tmp/gr-cyberradio/libcyberradio/libcyberradio/Driver/RadioTransport.cpp: In member function 'virtual bool LibCyberRadio::Driver::RadioTransport::sendCommandHttps(const string&, bool)':
/tmp/gr-cyberradio/libcyberradio/libcyberradio/Driver/RadioTransport.cpp:404:34: warning: 'Reader' is deprecated: Use CharReader and CharReaderBuilder instead. [-Wdeprecated-declarations]
                     Json::Reader reader;
                                  ^~~~~~
In file included from /opt/foss/include/json/json.h:11,
                 from /tmp/gr-cyberradio/libcyberradio/libcyberradio/Driver/RadioTransport.cpp:15:
/opt/foss/include/json/reader.h:37:63: note: declared here
     "Use CharReader and CharReaderBuilder instead.") JSON_API Reader {
                                                               ^~~~~~
/tmp/gr-cyberradio/libcyberradio/libcyberradio/Driver/RadioTransport.cpp:404:34: warning: 'Json::Reader::Reader()' is deprecated: Use CharReader and CharReaderBuilder instead [-Wdeprecated-declarations]
                     Json::Reader reader;
                                  ^~~~~~
In file included from /opt/foss/include/json/json.h:11,
                 from /tmp/gr-cyberradio/libcyberradio/libcyberradio/Driver/RadioTransport.cpp:15:
/opt/foss/include/json/reader.h:56:3: note: declared here
   Reader();
   ^~~~~~

The deprecation warnings should be addressed.

crs-bs commented 3 years ago

What's the version of libjsoncpp?

jwmelto commented 2 years ago

Looks like jsoncpp 1.9.5 removed the deprecation warnings. It was an interesting choice; either it's deprecated or it isn't. Guess it isn't.