CyberShadow / Digger

A tool to build D and bisect old D versions
Other
57 stars 9 forks source link

[minor] digger crashes when you view the usage instructions #39

Closed Cauterite closed 7 years ago

Cauterite commented 8 years ago
c:\digger> digger.exe
Digger v2.4 - a D source code buil...
...
std.getopt.GetOptException@ae\utils\funopt.d(293): No action specified
----------------
0x0047058E
...

So it does its job of printing the usage instructions, but also dumps an ugly stack trace at the end of the output. Not a major problem, but it is a little confusing initially (notice stack trace -> assume something's gone wrong).

CyberShadow commented 8 years ago

It only does that if you compile with -debug, so I think we're all good here.

Cauterite commented 8 years ago

Then we are blocked by https://github.com/CyberShadow/Digger/issues/37 ;P

CyberShadow commented 7 years ago

Closing as this one is not really actionable.

timotheecour commented 7 years ago

how about: in ./ae/utils/main.d

debug return run(args); =>

auto fun(){
try return run(args);
catch(...){...}
}
version(workaround_issue_37) return fun(args);
else debug return run(args);
else return fun(args);

and then in instructions in README: write: rdmd --build-only -debug -version=workaround_issue_37 digger

CyberShadow commented 7 years ago

Not a fan of temporary workarounds for bugs in other projects, especially for cosmetic issues. It would be more effective to complain to get the underlying DMD regression fixed.