search

CyberShadow / Digger

A tool to build D and bisect old D versions
Other
57 stars 9 forks source link

Allow https:// to be used for git repo URLs #70

Closed JackStouffer closed 5 years ago

JackStouffer commented 6 years ago

Many corporate firewalls block git:// which makes digger unusable.

CyberShadow commented 6 years ago

This is caused by a (user-hostile :wink:) configuration at the user site, so I think it should ideally be fixed there. Git provides a simple workaround that will fix this issue globally (for all git usage by the user):

git config --global url."https://".insteadOf git://

We could detect this situation and suggest this workaround, though it's probably simpler to just switch the URLs to https...

JackStouffer commented 6 years ago

Copying from the slack discussion:

Doesn't seem to be working for cloning dmd

It's suck at

Submodule 'dmd' (git://github.com/dlang/dmd) registered for path 'dmd'
Cloning into '/Users/Jack/digger/work/repo/dmd'...
CyberShadow commented 6 years ago

I don't know what could be wrong, sorry. I know that workaround was used with success in the past, so maybe check the process list or network traffic to check if it's really going through HTTPS?

CyberShadow commented 5 years ago

I know that workaround was used with success in the past,

Oops, looks like that only works on Windows, because we tell git to not use the system-wide configuration elsewhere (to ensure it doesn't pollute the build).

d4dad99fc04abc4ffce401e2cb78a160ed66b1d7 adds a new setting that can be used to achieve this.