search

CyberShadow / Digger

A tool to build D and bisect old D versions
Other
57 stars 9 forks source link

digger ini file wrongly states that master is the default branch. #88

Closed ghost closed 3 years ago

ghost commented 3 years ago

For this bug: https://issues.dlang.org/show_bug.cgi?id=21163

if you use this ini : 

# Starting points.
# Known bad (with regression) and good (w/o regression) commits.
# Digger will verify these commits to avoid a false conclusion.
# Supported formats:
# - "master" (implies latest commit)
# - SHA-1 hash of D.git repo commit
# - SHA-1 hash of a component's repo commit
#   (must be a pull request merge commit)
# - Full GitHub URL of a pull request, e.g.:
#   https://github.com/dlang/dmd/pull/123
# - Optionally, "@" followed by a time spec (e.g. "@ 2013-01-02",
#   "master @ October 2013", "2.065 @ 15 days ago" or "@ Tuesday")
#   or a tag (e.g. "master @ v2.085.0).
#   If no ref is specified, master is assumed.

bad  = v2.081.1
good = v2.079.0
reverse = false
tester = dmd -o- b21163.d

[environment]
[build]

components.enable.rdmd = false

digger will find merge commits.

but if you use this one

# Starting points.
# Known bad (with regression) and good (w/o regression) commits.
# Digger will verify these commits to avoid a false conclusion.
# Supported formats:
# - "master" (implies latest commit)
# - SHA-1 hash of D.git repo commit
# - SHA-1 hash of a component's repo commit
#   (must be a pull request merge commit)
# - Full GitHub URL of a pull request, e.g.:
#   https://github.com/dlang/dmd/pull/123
# - Optionally, "@" followed by a time spec (e.g. "@ 2013-01-02",
#   "master @ October 2013", "2.065 @ 15 days ago" or "@ Tuesday")
#   or a tag (e.g. "master @ v2.085.0).
#   If no ref is specified, master is assumed.

bad  = master @ v2.081.1
good = master @ v2.079.0
reverse = false
tester = dmd -o- b21163.d

[environment]
[build]

components.enable.rdmd = false

Then the exact culprit is found.

so If no ref is specified, master is assumed. is not right. It lloks like it's rather 'stable @' that's used when no branch is specified.

CyberShadow commented 3 years ago

The ref in the first example is the v2.081.1 tag. D releases have always been tagged on the stable branch since its introduction.

ghost commented 3 years ago

ok I see, so no real problem here, but i can add this to the comment of the template.

ghost commented 3 years ago

thanks again for the explanations.