CyberShadow / Digger

A tool to build D and bisect old D versions
Other
57 stars 9 forks source link

add incremental builds #9

Closed snosov1 closed 9 years ago

snosov1 commented 9 years ago

To perform an incremental build, provide a --incremental flag to the build command.

Needs https://github.com/CyberShadow/ae/pull/10

CyberShadow commented 9 years ago

I think it should be a separate command, because we effectively ignore the parameter to "build" now. Any reason for making it a switch?

snosov1 commented 9 years ago

No particular reason. Just wanted to reuse the code.

Obviously, the duplication can be alleviated by introducing some function.

snosov1 commented 9 years ago

No particular reason. Just wanted to reuse the code.

Obviously, the duplication can be alleviated by introducing some function.

Best regards, Sergei Nosov

On Tue, Dec 2, 2014 at 5:47 PM, Vladimir Panteleev <notifications@github.com

wrote:

I think it should be a separate command, because we effectively ignore the parameter to "build" now. Any reason for making it a switch?

— Reply to this email directly or view it on GitHub https://github.com/CyberShadow/Digger/pull/9#issuecomment-65240888.

CyberShadow commented 9 years ago

No need for that, just add a switch case like what's done with "build-all". I think "rebuild" would be better, shorter to type too.

snosov1 commented 9 years ago

Ok, I did this, but github is acting weird for me today. Most of the time I can't even ping it.

I will update the PR next time I have a chance.

Best regards, Sergei Nosov

On Tue, Dec 2, 2014 at 5:54 PM, Vladimir Panteleev <notifications@github.com

wrote:

No need for that, just add a switch case like what's done with "build-all". I think "rebuild" would be better, shorter to type too.

— Reply to this email directly or view it on GitHub https://github.com/CyberShadow/Digger/pull/9#issuecomment-65242057.

CyberShadow commented 9 years ago

That's OK, I'll fix it up myself then. Thanks.

CyberShadow commented 9 years ago

b32b4814e3715c7777f52b52706471757b41a5ca

And documented in d3fdd54018896d186007f66ab6536fa782502868

snosov1 commented 9 years ago

:+1: