CyberShadow
commented
2 years ago @GoTeamScotch Hi, please try the builds here (or build with these commits) and use the filter with the option blend set to 0.
Open GoTeamScotch opened 2 years ago
CyberShadow
commented
2 years ago @GoTeamScotch Hi, please try the builds here (or build with these commits) and use the filter with the option blend set to 0.
This ticket is a continuation of a conversation you and I had back in 2021 via email. I've tried writing to you again, but I'm not sure if my messages are coming through.
The photosensitivity filter you've made is a great addition to ffmpeg and has powerful potential as a means of improving accessibility for people living with photosensitivity / epilepsy. I wanted to give some feedback and make a suggestion if I may with input coming from a person I am close to who lives with photosensitivity.
The feedback she gave is that the blur effect that the filter applies is very aggressive and it deters from the movie/show watching experience. Back in 2021, I made a suggestion via email to simple hold a single frame (or reduce the video's framerate temporarily) while a period of strobing is occurring. The idea behind this change/addition is that a viewer may find it difficult to see and understand what it being shown on screen if the image is too blurry. If there is motion happening on screen while strobing is occurring, for example, it can be hard to see what is happening due to how blurry the video becomes as the filter tries to blend adjacent frames.
You made a change to the filter's code and sent me a build to test with, but I unfortunately lost it when I got a new PC earlier this year. The change you made is this: _"In vfphotosensitivity.c, there is the line:
if (factor <= 0) {. If you change it toif (1) {, the filter will always duplicate the previous frame (effectively freezing it) as long as the badness exceeds the threshold."You also sent this as a test case, using a sample video I provided. scavengers-comparison.mp4
The feedback I got from the person I mentioned above was very positive. This helped her see what was happening without the video becoming too blurred/blended. This is probably a personal preference that will vary from person to person. In our case at least, it was a noticeable improvement in the movie watching experience.
Hopefully this can eventually find its way into the main ffmpeg project. If this is simply added as another optional parameter (or tweak to an existing param), that would be perfect. Then existing users wouldn't be affected and this would just be an added option.
P.s. My ultimate goal is to use this version of ffmpeg+photosensitivity in my Jellyfin server and transcode videos on-the-fly as needed, that way I don't have to re-encode all of my ideo library. I've already looked into that and found a path for achieving it.
Thanks