Observe the effect of the change (test suite fallout)
Amend the merge commit with any necessary fix-ups, such as conflicts and test-suite updates
If the grammar change has the desired expected effect, submit it upstream.
Previously, all upstream submissions have been using a linear history. However, as the complexity of the fixes has continued to rise from trivial DDoc syntax fixes to non-trivial grammar changes, reviewing a linear history has become increasingly impractical. For this reason, individual grammar fixes ought to be submitted upstream as individual pull requests.
As our fixes are no longer contained within a single PR, this issue will be used to track the submission status of our grammar fixes:
When tree-sitter-d does not behave correctly due to an error in the language specification, the workflow for fixing the problem is as follows:
grammar.js
file on thegenerated
branch, and commit any changes plus the submodule updategenerated
branch into themaster
branchPreviously, all upstream submissions have been using a linear history. However, as the complexity of the fixes has continued to rise from trivial DDoc syntax fixes to non-trivial grammar changes, reviewing a linear history has become increasingly impractical. For this reason, individual grammar fixes ought to be submitted upstream as individual pull requests.
As our fixes are no longer contained within a single PR, this issue will be used to track the submission status of our grammar fixes:
You can help by reviewing or assisting reviewers of the upstream PRs.