search

CyberSource / cybersource-rest-client-dotnet

.NET client library for the CyberSource REST API
Other
19 stars 44 forks source link

Various model objects are missing "id" field #119

Open wrightsonm opened 3 years ago

wrightsonm commented 3 years ago

Having analysed many production messages I have found the following object types are missing the field "id" This analysis only includes error messages.

Could not find member 'id' on object of type 'PtsV2PaymentsPost400Response'. Path 'id', line 2, position 32.
Could not find member 'id' on object of type 'PtsV2PayoutsPost400Response'. Path 'id', line 2, position 32.
Could not find member 'id' on object of type 'PtsV2PaymentsPost502Response'. Path 'id', line 2, position 32.
Could not find member 'id' on object of type 'RiskV1AuthenticationsPost400Response'. Path 'id', line 2, position 32.

The following code should be added / openapi spec updated:

/// <summary>
        /// An unique identification number to identify the submitted request. It is also appended to the endpoint of the resource.  On incremental authorizations, this value with be the same as the identification number returned in the original authorization response.  #### PIN debit Returned for all PIN debit services. 
        /// </summary>
        /// <value>An unique identification number to identify the submitted request. It is also appended to the endpoint of the resource.  On incremental authorizations, this value with be the same as the identification number returned in the original authorization response.  #### PIN debit Returned for all PIN debit services. </value>
        [DataMember(Name="id", EmitDefaultValue=false)]
        public string Id { get; set; }
wrightsonm commented 3 years ago

PtsV2PaymentsRefundPost400Response is also missing id field