search

CyberSource / cybersource-rest-client-dotnet

.NET client library for the CyberSource REST API
Other
19 stars 44 forks source link

CyberSource.Authentication has dependency on NUnit. Is this neccessary? #187

Open le-dhogan opened 2 months ago

le-dhogan commented 2 months ago

This library has a dependency on CyberSource.Authentication which has a nuget project url of https://github.com/CyberSource/cybersource-rest-auth-dotnet

This project repo returns a 404 so I'm assuming it's a private / closed source project? Is this intentional?

My issue is that CyberSource.Authentication has a dependency on NUnit (>= 3.10.1) Is there a reason for this library bundling a Test Framework?

Thanks

spx-mw commented 2 months ago

the .netstandard version is open source:

https://github.com/CyberSource/cybersource-rest-client-dotnetstandard/blob/master/cybersource-rest-auth-netstandard/AuthenticationSdk/AuthenticationSdkTests.NetCore/AuthenticationSdkTests.NetCore.csproj

but still contains nunit reference.

le-dhogan commented 2 months ago

Thanks @spx-mw - very useful to see this netstandard source! The project file you linked is the actual Test project so expect NUnit usage usage in that.

Interestingly though, https://github.com/CyberSource/cybersource-rest-client-dotnetstandard/blob/master/cybersource-rest-auth-netstandard/AuthenticationSdk/AuthenticationSdk/AuthenticationSdk.csproj doesn't seem to have NLog reference. This is versioned as v0.0.1.14 whereas the published latest package for this is v0.0.0.20.

Seems that anyone referencing CyberSource.Rest.Client or CyberSource.Authentication is being forced to bring in NUnit and it feels like this should be fixed.