search

CyberSource / cybersource-rest-client-dotnetstandard

.NET Standard client library for the CyberSource REST API
7 stars 21 forks source link

ApiClient creates new instance of RestClient #39

Open sipsorcery opened 2 years ago

sipsorcery commented 2 years ago

While attempting, and failing, to set the timeout for HTTP calls to the CyberSource gateway via the Configuration.Timeout I tracked it down to a second instance of the RestClient being created.

I'm not really sure what the code is meant to be doing at that point. It seems like ApiClient creates a RestClient instance in its contructor with the intention of using it for the API call. Configuration values are applied to that instance. But then a brand new instance is created in CallAuthenticationHeaders and it does not have the Configuration values applied.

I can fix my problem by changing:

RestClient = new RestClient("https://" + merchantConfig.HostName);

to

RestClient.BaseUrl = new Uri("https://" + merchantConfig.HostName);

It does seem to be a somewhat confusing and error prone approach. It would seem better to stick to setting the hostname in the ApiClient constructor rather than burying it down in an entry in the Configuration.MerchantConfigDictionaryObj dictionary.

sebastian-sawicki commented 2 years ago

This issue is related with issue https://github.com/CyberSource/cybersource-rest-client-dotnetstandard/issues/26 which my team reported. We also pointed to CallAuthenticationHeaders where new instance of RestClient is recreated.

I raise also separate https://github.com/CyberSource/cybersource-rest-client-dotnetstandard/issues/46 "Update RestSharp to v107 and follow recommended usage".

DatMarsupial commented 1 year ago

My team and I would also love to see this resolved! We're trying to create a custom delegating handler in our pipeline