search

Cyberboss / install-winget

Action to install latest winget CLI on Windows runners
GNU Affero General Public License v3.0
14 stars 2 forks source link

Make failure message more clear help issue #8 #9

Closed blessio closed 3 weeks ago

blessio commented 3 weeks ago

Related to issue #8.

When this code is added the error message shows the root-cause why #8 happens. It does not resolve the issue, rather proves that the error is to be fixed in the bundler of winget or VCLibs or Desktop installer.

Although the issue is not fixed, this PR makes the code easier to maintain so I suggest merging it.

blessio commented 3 weeks ago

Thanks for accepting the merge. Now the issue can be seen here on builds "Test Latest with ... ". Link to one of them: https://github.com/Cyberboss/install-winget/actions/runs/11652279817/job/32443276681#step:2:90

That is why I think that this tests should be given to winget-cli team (https://github.com/microsoft/winget-cli), and a release of winget-cli should not be done until these tests pass ...