Open cccs-mk opened 11 months ago
The use cases I can think of for having an externally-configurable ObjectMapper
feel fairly niche:
ObjectMapper
config in their own repo rather than wait for the AL client to be updated.
Maybe it would be sufficient to just add new constructor that doesn't accept an ObjectMapper
(and then create an instance ourselves).
We could add documentation to the old constructor that says something like, "It's up to you to provide an ObjectMapper
that works." At that point, though, does it still make sense for AssemblylineClient
to do any configuration of the mapper?
I've marked the ObjectMapper
-accepting constructor as deprecated. It's probably safe to remove, but I don't know exactly how other people are using this library.
Originally posted by @cccs-mk in https://github.com/CybercentreCanada/assemblyline-java-client/issues/26#issuecomment-916327760