CybercentreCanada / assemblyline

AssemblyLine 4: File triage and malware analysis
https://cybercentrecanada.github.io/assemblyline4_docs/
MIT License
243 stars 15 forks source link

assemblyline-service-safelist bug in update_server.py #256

Closed BolidCyber closed 1 month ago

BolidCyber commented 1 month ago

Describe the bug in assemblyline-service-safelist project version 4.5.0.stable13, the method declaration import_update have three parameters but the call have four parameters

To Reproduce Steps to reproduce the behavior:

  1. Go to assemblyline-service-safelist project with tag V4.5.0.stable13
  2. Open file update_server.py
  3. line 196 def import_update(self, file_path, source_name: str, default_classification=None):
  4. line 330 self.import_update(file, self.client, source_name, default_classification)

Expected behavior No errors during NSRL updates

Screenshots NA

Environment (please complete the following information if pertinent):

Additional context NA

cccs-rs commented 1 month ago

Should be patched in the latest release of the service. Thanks for raising the issue to us!