CybercentreCanada / assemblyline

AssemblyLine 4: File triage and malware analysis
https://cybercentrecanada.github.io/assemblyline4_docs/
MIT License
249 stars 15 forks source link

Malware Archive Verdict Conclusion Takes Max Instead of Sum of Scores #271

Open jflowers00 opened 1 month ago

jflowers00 commented 1 month ago

Describe the bug When a file is in the Malware Archive, the verdict is calculated from the max of all scores in the services. Files in the Submissions will have the verdict determined from the added scores from each service, as documented here: https://cybercentrecanada.github.io/assemblyline4_docs/user_manual/verdicts/

"Service scores for a single file are added together to create a total score for that file."

To Reproduce Steps to reproduce the behavior:

  1. Submit malware sample 0000f08c93fda4efc62866b51d73efabb2103cb373d1db144cf3250e7615b18b
  2. Observe Malicious Verdict with scores added together
  3. Archive the file
  4. Final Verdict will be different

Expected behavior The verdict should be consistent between the submissions and archive.

Environment (please complete the following information if pertinent):