search

CybercentreCanada / jupyterlab-sql-editor

A JupyterLab extension providing, SQL formatter, auto-completion, syntax highlighting, Spark SQL and Trino
BSD 3-Clause "New" or "Revised" License
83 stars 13 forks source link

THANK YOU! #51

Open goodwanghan opened 2 years ago

goodwanghan commented 2 years ago

Hi,

I want to thank you for creating this wonderful project. We recently created and open sourced https://github.com/fugue-project/fugue-jupyter which is heavily inspired by your work. Although we are not able to directly leverage this project because Fugue SQL has more syntax than standard SQL, we learned a lot from this project.

For now, we only enabled highlights, in the future we will also enable auto formatting and probably auto completion. You have all of them, that is amazing!

Han

cccs-jc commented 2 years ago

Hey @goodwanghan happy to hear this is of interest. I notice you are copying code for your needs.

It might be better if you used the the jupyterlab-sql-editor as a component in your project. Maybe with a bit of refactoring it would be reusable for your usecase.

I'm on vacation at the moment but would very much appreciate discussing this further with you.

surjansr commented 2 years ago

@cccs-jc @cccs-nik @cccs-mmrouet- huge thanks for creating this project. I am trying this out for my use case and able to use it when I install it from the running notebook but pre-configuration is not working. Is there any mailing-list or group to discuss any issues faced while using it before creating a git issue ?

cccs-jc commented 2 years ago

@surjansr we don't yet have a discussion board yet. So feel free to discuss here in the meantime.

Are you planning to use the extension as part of another project or use it as is?

cccs-jc commented 2 years ago

@goodwanghan I'm back from vacation. Would you like to discuss integration of our tool into your project?

surjansr commented 2 years ago

Are you planning to use the extension as part of another project or use it as is?

Planning to use it as is for now and also to contribute to this super cool project but my contribution will only come after I am approved to do that.