search

CyberdyneCC / Thermos

(NO LONGER DEVELOPED) Minecraft Forge Server Software implementing the Spigot/Bukkit API, formerly known as Cauldron/MCPC
http://cyberdynecc.github.io/Thermos/
GNU General Public License v3.0
256 stars 184 forks source link

[To Do] Grab changes from PaperSpigot and Implement Here #32

Open sameer opened 8 years ago

sameer commented 8 years ago

The creators of PaperSpigot have implemented many fixes that KCauldron does not have and desperately needs. If anyone is willing to help, we need to start sorting through the .patch files from 1.7.10 here to find what fixes KCauldron does not have. UPDATE: The following folders are relevant:

If you find a fix, please make a pull request. If you are not a Git User, this is easy to do. Just find the right file, there is an edit button where you can change the file and easily create a pull req.

Yive commented 8 years ago

That's 1.8 Paperspigot. This is 1.7 Paperspigot https://github.com/PaperSpigot/Paper-1.7

sameer commented 8 years ago

@Yive Ah, thanks. Also, found that PaperSpigot fixed the out of synch issue themselves... see here. We cannot implement this because of mods accessing the TreeSet though. :confused:

ghost commented 8 years ago

Hey there, I'm going to list all the PaperSpigot patches I find in here until I can find out how to submit PRs, once I find out how, I'll start PRing.

Not entirely sure, but from reading this commit, it seems this may fix the "Player moved wrongly" spam I get in console on a frequent basis.

Fix broken movement caused by mutated location in PlayerMoveEvent. http://pastebin.com/rCq8tWnt

Damn you move quickly.

Stops Spigots built in anti x-ray from queuing updates if you've disabled it. http://pastebin.com/CYBUvwN8

I'll update this as I go through the patches.

EDIT: Would it be possible for you to remove the max-tile-entity-tick option that is in KCauldron current? reason being, Cauldron already adds this in and makes Spigots completely redundant.

sameer commented 8 years ago

@iKaneki-Ken 0.o Didn't know cauldron added it...I'll get rid of it once I find it.

ghost commented 8 years ago

@Robotia Cauldron added in a way to control TE ticks on a per TE basis, it's controlled through the tile-entity.yml. It's why I question why Spigots TE tick patch was implemented in the first place.

sameer commented 8 years ago

@iKaneki-Ken Oh I thought those were the same thing...! Well now I know :smile: I'll probably get rid of the Cauldron one, since the Spigot one is actually configurable...

ghost commented 8 years ago

The Cauldron one is more configurable than the Spigot one. Here is a link to the config file for Cauldrons version of TE tick limiting.

http://pastebin.com/9uhHByH6

As shown, Spigots TE tick limiting feature is actually inferior to Cauldrons.

sameer commented 8 years ago

@iKaneki-Ken Oh good point...forgot about individuality. I'll see if I can add those max tick time bits into cauldron.

sameer commented 8 years ago

Update: Most of the fixes from the craft Bukkit patches folder have been implemented.

Bogdan-G commented 8 years ago

PS 1.7 it backport version PS 1.8. Its structure and fixes can not always be applied, as they are for vanilla and primarily 1.8. I noticed that part of the revisions of the PS were applied in an era when the output of the official builds Сauldron. Prototik already applied the part patches of the way. I have not enough knowledge of Java and the structure of the server to transfer the more complicated changes.

P.S. I noticed that when you make edits, we forget about the folder: src\main\java\net\minecraftforge\cauldron. Eclipse folder does not contain all that for compiled.

Bogdan-G commented 8 years ago

@iKaneki-Ken EDIT: Would it be possible for you to remove the max-tile-entity-tick option that is in KCauldron current? reason being, Cauldron already adds this in and makes Spigots completely redundant. - ask Prototik why he did a patch of tick-limiter spigot. I still wish to remove this patch.

ghost commented 8 years ago

@Bogdan-G @Robotia I'm wondering if it would be possible to start off where Cauldron left off. I find it would be better that way as I find that some things that were changed in KCauldron broke certain things rather than fixed.

Bogdan-G commented 8 years ago

@iKaneki-Ken vague concept of the word fix, for each kind is its value. So that coming out do not change what you need or what they were doing.

ghost commented 8 years ago

Eh, well, to clarify what I mean, fix/optimize. As it stands, I ran 2 servers, one with Prototik's KCauldron and one with Robotia's (K)Cauldron. The performance increase in Robotia's was very evident, legitimately 50% lower tick time on startup, and with 30~ players on, 15-25ms per tick.

Bogdan-G commented 8 years ago

@iKaneki-Ken my modifications may be falling TPS(I think the fact I'm using a weak outdated hardware for server hosting, because the main computer much less problem with a tps), all objects of the world ticking less than 25 ms(and it is on weak computer)

sameer commented 8 years ago

@iKaneki-Ken Sorting through the Spigot patches and applying them took me lots of time, I do not think I could do that for the entirety of KCauldron :confused:

sameer commented 8 years ago

@Bogdan-G We will need to look at GitLab commits then

Time6628 commented 8 years ago

I can work on this, just tell me what you want implemented into thermos and I will try my best :smile_cat:

ghost commented 8 years ago

Patches to hopefully add:

https://github.com/PaperMC/Paper/commit/ce9e19cfed86bf3709fc917bd62358f994cb22b5
https://github.com/PaperMC/Paper/commit/28bf70ee16958253fcff784f220e23dec00afa27
https://github.com/PaperMC/Paper/commit/3f0e24eaf377e1e67c0ae6f36be16e9733fff351
https://github.com/PaperMC/Paper/commit/4becba32a6d20587ecdffe9ebbc5047a3f02590a
https://github.com/PaperMC/Paper/commit/ba9266a37b99b01aaa50c0881819128d921aada3
https://github.com/PaperMC/Paper/commit/cdd926c1e9fc882a1a5c179f3f7a8ee3e1d7766b
https://github.com/PaperMC/Paper/commit/8e68f444f1ef9c9d39bc19c9657a24d8a9b1c5c8
https://github.com/PaperMC/Paper/commit/dea2d41b86e2a749251e12dd33439a08e9622dba
https://github.com/PaperMC/Paper/commit/0ba94906ad0e0cab57238b1c8c962087f1975be2
https://github.com/PaperMC/Paper/commit/91d9131e0c0eba7836719e272f7398bec0e54ea7
https://github.com/PaperMC/Paper/commit/c09424fd33982123d7ed883cd51bdda1c0b63b55
https://github.com/PaperMC/Paper/commit/e11c563e9f1f16ddd2f83ea61406a822269b601c
https://github.com/PaperMC/Paper/commit/7c7f8b83abeab860159293b13089b67f2a4b3d0d
https://github.com/PaperMC/Paper/commit/443691d22da7722e59295f1e21e95d185ce01bdb
https://github.com/PaperMC/Paper/commit/e1db75896c596b1e23e5b4b9c54235c49028809a
https://github.com/PaperMC/Paper/commit/bb17101d59286ef6b4e1968eca1e8a39d2dc99cb