search

CyberdyneCC / Thermos

(NO LONGER DEVELOPED) Minecraft Forge Server Software implementing the Spigot/Bukkit API, formerly known as Cauldron/MCPC
http://cyberdynecc.github.io/Thermos/
GNU General Public License v3.0
258 stars 184 forks source link

Removed FlatMap to improve performance #407

Closed dogboy21 closed 8 years ago

sameer commented 8 years ago

Hello,

What kind of performance improvements did you see with this change?

Thanks,

Robotia

dogboy21 commented 8 years ago

Unfortunately I don't have any screenshots from the WarmRoast measurement yesterday, but the initialization of a FlatMap took about 30% of the server load on one of our servers.

TPS Graph Here you can see the TPS graph of said server. You see the jump in the middle of the graph? Thats the time when I updated the server to the fixed version. Overall we noticed improvements of about 2-5 TPS on every of our 30 servers. Also the FlatMap was removed ages ago from Spigot/CraftBukkit because of memory leaks and other performance problems as you can see here and here

ghost commented 8 years ago

@dogboy21 Thank you for this! Honestly, thank you!

usernameak commented 6 years ago

Side effect: WorldEdit //regen doesn't work

dogboy21 commented 6 years ago

I think //regen was broken for a long time on modded servers. Are you sure that this PR is causing the problem? IIRC it only added a patch which was part of Spigot for a long time.

sameer commented 6 years ago

Was about to note this as well -- are you using the world edit plugin? If I am remembering correctly, they did develop a forge oriented version of it as a mod.

On Thu, May 17, 2018, 07:33 Dogboy21 notifications@github.com wrote:

I think //regen was broken for a long time on modded servers. Are you sure that this PR is causing the problem? IIRC it only added a patch which was part of Spigot for a long time.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FCyberdyneCC%2FThermos%2Fpull%2F407%23issuecomment-389887853&data=02%7C01%7Csameer.puri%40mail-service-3-mx.vanderbilt.edu%7Cca759aa795914d380f9308d5bc031a9a%7Cba5a7f39e3be4ab3b45067fa80faecad%7C0%7C0%7C636621643874501796&sdata=gfVXdMzYdmQ4FYJVGMnx4Gk%2FDxkyrj6EjtjzGKoRnIQ%3D&reserved=0, or mute the thread https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKlUCHUYGg6iOI2zCEBwEV1TjDDFfnGDks5tzYoggaJpZM4I3nGm&data=02%7C01%7Csameer.puri%40mail-service-3-mx.vanderbilt.edu%7Cca759aa795914d380f9308d5bc031a9a%7Cba5a7f39e3be4ab3b45067fa80faecad%7C0%7C0%7C636621643874501796&sdata=PC5DkQMh3X1l4CzcOqtx8egTHPor6sRlGrkwrfdkL%2F4%3D&reserved=0 .

SantaGitHub commented 6 years ago

@usernameak use this patch for thermos 58 https://yadi.sk/d/4KrI2qYp3RDAgV