CyberfusionIO / cyberfusion-cluster-api-client

Cyberfusion Core API client
https://core-api.cyberfusion.io
MIT License
5 stars 3 forks source link

Sync nullable attributes with Cluster API #7

Closed WilliamDEdwards closed 3 months ago

WilliamDEdwards commented 2 years ago

The attributes that are marked as nullable and non-nullable are out of sync between the Cluster API and the client. Every attribute should be checked and updated if needed.

dvdheiden commented 2 years ago

To fully match the objects in the Cluster API, we could consider using the create/update models from the Cluster API. Right now, the models in this package represent the entity (i.e. VirtualHost) and are used for all CRUD actions.

That will be a breaking change, so let's discuss this first.

WilliamDEdwards commented 4 months ago

When doing the major version increase, change all references to Cluster API to Core API (what I wanted to do in https://github.com/CyberfusionIO/cyberfusion-cluster-api-client/pull/114).

WilliamDEdwards commented 3 months ago

Will be automatically fixed by https://github.com/CyberfusionIO/cyberfusion-cluster-api-client/issues/117