Cyberhan123 / stable-diffusion-desktop

Minimalist stable-diffusion desktop application with only one executable file writen with golang ( No python ).
GNU General Public License v3.0
17 stars 1 forks source link

new ideas #9

Open Amin456789 opened 8 months ago

Amin456789 commented 8 months ago

Hi i though to make a new topic to share new ideas

1.batch image save, it will be great to save all the images at once if possible 2.images have no .png or .jpg at the end of when saving them = i mean when i try to save the images i have to put .png at the end of image manually, please fix if possible

  1. preset saving = it will save lots of time if we can make presets of our settings, for example when i choose taesd path and lcm sampler or etc... i can save as a preset so all i need is to load it from now on than selecting them again
  2. the app sometimes is being closed by itself randomly like after saving the image

thank u so much for this lovely app

Amin456789 commented 8 months ago
  1. please add clip skip feature if possible as some models need it for better images
  2. app closes when i click on generate again after i generate 1 image or aftehr batch count, please fix it if possible

can't wait for img2img also! thank u so much for everything

JohnClaw commented 8 months ago

6. app closes when i click on generate again after i generate 1 image or aftehr batch count, please fix it if possible

I found a way how to avoid this bug. Before clicking generate button you should change RNG and Schedule in Settings.

Cyberhan123 commented 8 months ago
  1. app closes when i click on generate again after i generate 1 image or aftehr batch count, please fix it if possible

I found a way how to avoid this bug. Before clicking generate button you should change RNG and Schedule in Settings.

Ok,I need test full.

Cyberhan123 commented 8 months ago

@Amin456789 The crash of the program is related to this problem. https://github.com/leejet/stable-diffusion.cpp/issues/146. I have created a related issue and currently disabled this parameter in the app.

Amin456789 commented 8 months ago

thank u for this

Cyberhan123 commented 8 months ago

I'm sending an emergency fix now, and will improve the picture and settings issues later, they are very simple

Amin456789 commented 8 months ago
  1. it will be great if prompt section can go over 75 token too, 150 is good i think
  2. my laptop screen is 1366x768, i can barely see batch count, could u please somehow make the ui more comfortable with laptop screens like mine, thnx
Cyberhan123 commented 8 months ago
  1. it will be great if prompt section can go over 75 token too, 150 is good i think
  2. my laptop screen is 1366x768, i can barely see batch count, could u please somehow make the ui more comfortable with laptop screens like mine, thnx

This is not my limit, you can see it is the clip modle limit of sd itself

Cyberhan123 commented 8 months ago

In other words, if you exceed it, it will be ignored.

Amin456789 commented 8 months ago

oh that's why in the past my images mostly were bad as it was ignoring my words when i was over 75, thank u for the answer

Amin456789 commented 8 months ago

hey cyberhan, i see u merged the new update, could u please release the exe in releases section too as i cant compile it myself. it seems u fixed everything in the new update so im gonna close this if its ok with u,

btw, iv read ur oigin.md, thank u so much for making this app, this is my favroite gui right now and i deleted every sd webui and only using this, thank u for mentioning me and please keep up the good work, this app will rock in the future, leejet should add this to the read me in his page, please ask him

Cyberhan123 commented 8 months ago

There is a frustrating problem. Although I found the reason, I am weighing how to deal with it. VaeDecodeOnly can be turned on and off in txt2img, but in img2img mode, it must remain turned off, otherwise the program will crash. The problem lies in table-diffusion There is currently no API for setting options, otherwise we need to reload the model and re-initialize it again, so I plan to submit a PR to modify the current logic of stable-diffusion.cpp

Cyberhan123 commented 8 months ago

By the way, I recommend you keep other webui that you don't need to use just this one, it stresses me out a lot and I'm doing this in my spare time.

Amin456789 commented 8 months ago

thank u for ur hard work, please dont stress out, do it any time u can, even if it takes months to fix something its all great, i though u fixd and merged it that is why i asked for it, otherwise pelase dont hurry,

Amin456789 commented 8 months ago

tnx for the new update but i think img2img is broken, it doesnt matter what setting i choose, it always gives me the same image i gave it to it excacly, and sometimes it even jump out of the program like using batch count, i am using lcm dreamshaper 7

Amin456789 commented 8 months ago

another bug is when i choose fp16 in always makes the fp16 model fp32, and i have load it once then go to the app and rechoose so it can load it in fp16 again, it will be great it automaticly always choose the weight's type like in sd cpp

Amin456789 commented 8 months ago

what about u johnclaw, please report all bugs

Cyberhan123 commented 8 months ago

tnx for the new update but i think img2img is broken, it doesnt matter what setting i choose, it always gives me the same image i gave it to it excacly, and sometimes it even jump out of the program like using batch count, i am using lcm dreamshaper 7

@Amin456789 Can you give me a specific example? What model did you use to set what parameters? Automatically recommend wtype. I found this also problem, but I need to wait for the ci upgrade of sd.cpp to solve it. Because the type enumeration has been increased.

Cyberhan123 commented 8 months ago

Another thing to note is that the parameters are very important, because the sampling methods of some models can only output correctly under the correct parameters .

Amin456789 commented 8 months ago

i tested with lcm dreamshaper 7 and euler a and lcm sampler and euler also tested i think, and i put on 4 to 8 steps if i remember correctly and cfg 1 and 8 also i tested in many ways and it didnt work, i hope it get fixed with ur ci update for sd cpp

Amin456789 commented 8 months ago

btw cyberhan, tnx for all ur efforts, together with u and ur fans we will make this the best sd cpp out there, this is the future of sd as one single small app is the best and easier to use. long journey ahead with lots of new featuers such as svd and inainting outpinting, btw u should post ur app in stable diffusion section on reddit to people find it

Amin456789 commented 8 months ago

oh one reason that maybe img2img is not working is because i coulnd't find the strength option, could u add it it please from sd cpp, putting strenght to 0.7 gives different images than 0.30. maybe ur app is lack of strength is the problem

Cyberhan123 commented 8 months ago

I want to solve all the problems first and make this software really usable,Yeah I guess I overlooked this setting in my rush to publish, thanks.

Cyberhan123 commented 8 months ago

I think I need to add some interactive experiences:

  1. The same model directory settings, unified model path
  2. Can be loaded and released later.
  3. Can set the theme according to your own needs
  4. Model download page These are already planned and will be coming soon I think
Amin456789 commented 8 months ago

great, thank u

Amin456789 commented 8 months ago
  1. whenever we switch to text to img and img2img the model reloads again = please make it to not reload as sometimes it takes time specially with sdxl turbo as in the future when u fix vaedecode only the we can wait i guess
  2. i tested taesd and taesdxl and both works great, please add them to the feature as u forgot to remove taesd from todo list
Cyberhan123 commented 8 months ago

Yes, this is related to the API design of sd.cpp. https://github.com/leejet/stable-diffusion.cpp/issues/151

Amin456789 commented 8 months ago

great update, img2img works now thank u

  1. the settings change are like choosing fp type needs a restart of the app or we need to load the model and make the changes and load the model again to take the new fp effect [sdxl turbo needs to be 5.1 for me to work on my laptop]. not a deal breaker but it will be great if the app take the setting changes the first time we make changes
  2. it will be great if u adjust the app size for laptops with 1366x768, i need to use an app named altdrag to drag the app higher to see the bottom of the app as i can't see it when im about to save the image, or maybe u can just make the app that when we maximize it it shows all the options and whole app if possible, it will be a huge help to lots of people with laptops with lower resoulation

THESE suggestion i gave are not a big deal but will be great if we can have it someday, i am completly fine with whatever we got it is perfect to me

tnx again, great update, i like the auto save settings too,

Cyberhan123 commented 8 months ago

The current problem is that the option cannot be displayed when using 768px height. This is a UI design issue. Do you have any ideas?

Cyberhan123 commented 8 months ago

Yes the app needs to be restarted, I'm trying to implement set_options and load_model_from_file api.

Amin456789 commented 8 months ago

hmm no idea but there must be a way, as there are some apps when u maximisize the window the app displays every items even the screen is smaller than the app, or u can overhaul the app a bit more to fit with that size, but it is ok cyberhan don't mind it please, work on more important stuff and in the time something will spark and you can fix it then

Amin456789 commented 7 months ago

hey guys im back with new ideas=

  1. cyberhan, svd as u know its being slowly implented i thogh it will be great that u start to add the parametres and the section of svd in ur app slowly when svd is ready
  2. autosave of images and image location folder = it will be great if there is a seciton we choose for the image place in settings that the app auto save all images in there after images are generated as saving lots of images manually is lots of time consuming, also it will be great if the saved images get the prompt as the image name and put a number in front of the name if there is a batch image
  3. a button to reset all saved settings as there is no way i think to remove selected taesd if we dont wanna use it
  4. instead of choosing models we can select a folder for the models and the app can detect the models and list them so all we have to do is to select them via app
Cyberhan123 commented 7 months ago

I also discovered it, but since it’s Chinese New Year, I don’t have much time to do it.

Amin456789 commented 7 months ago

happy new year, hope u have a great year ahead, its all ok, make the new changes when the time is right

Cyberhan123 commented 6 months ago

I fixed the inability to clear VAE, and other settings that need to be cleared. Our company has laid off employees. Unfortunately, I am one of them. I am looking for a new full-time job until everything is stable. When the time comes, I will devote my free time to this project. Sorry to everyone who was looking forward to this project.