search

Cyborger1 / marks-of-grace-counter

A Runelite Plugin Hub plugin that counts marks of grace that spawn when doing agility rooftops
BSD 2-Clause "Simplified" License
2 stars 1 forks source link

Last Spawn Time methodology is incorrect #1

Closed ctdgunner closed 1 month ago

ctdgunner commented 1 month ago

Last spawn time starts counting from 0 from the game tick where the mark of grace is first seen. This isn't correct. The game only rolls the chance when a lap is completed. There should be a background timer that starts counting from the most recent lap completion and then commits this time to "last spawn" when it detects a mark. this will allow for tick perfectly predicting the 3 minute cooldown when farming marks.

ctdgunner commented 1 month ago

John Turner can explain this far better than I can: https://www.youtube.com/watch?v=ovqOB2LeHG4&list=PLOJsCHOKSDyLsUjhYjU-NSttmqZ5L3V5G&index=3

Additional detail is on the Wiki: Timing Marks

Cyborger1 commented 1 month ago

I added something that should work for you, however I left the alternate timing method off by default to not change the current behavior for existing users.

Once the above plugin hub pull request is merged, let me know if this is ok. If you have a plugin dev environment set up you may pull this repo and try it early as well.

Cyborger1 commented 1 month ago

Change was merged, please tick the "Use Lap Finish Mark Timing" config option and let me know if everything's good. image

ctdgunner commented 1 month ago

Yes this works as expected

Cyborger1 commented 1 month ago

If everything's good then I'm closing this issue, have a good day 🙂