search

Cyborger1 / marks-of-grace-counter

A Runelite Plugin Hub plugin that counts marks of grace that spawn when doing agility rooftops
BSD 2-Clause "Simplified" License
2 stars 1 forks source link

Add option for being notified when Marks of Grace are about to despawn #2

Open QuestingPet opened 6 days ago

QuestingPet commented 6 days ago

According to the wiki Marks of Grace despawn after 10 minutes. New marks of grace that stack on previous ones will reset the timer, useful for Ardy course.

While half-paying attention and sometimes AFKing, it would be nice if we could be notified if our stack of marks are about to despawn, so that we don't lose them. Perhaps a config that specifies the number of minutes to be notified since last spawn, and negative would disable it? Whatever you think works best.

Personally, I'd like to know if I only have a minute or two remaining until they despawn, so that I can make sure I don't AFK too long and can retrieve them. Especially if I'm watching a video or doing something else on my monitor and forget about it.

Let me know what you think. Thanks!

Cyborger1 commented 5 days ago

I put up a pull request on the plugin hub to add this feature, please let me know if everything's good when it's accepted and you get the update on your side.

Cyborger1 commented 4 days ago

Update is through, please let me know if it's good.

QuestingPet commented 3 days ago

Works perfectly! At first I was confused because it didn't work, but then I realized the setting is disabled by default (I just didn't bother looking). Seems to work great now, thanks! And thanks for the swift implementation!

QuestingPet commented 10 hours ago

So everything works great, though one additional suggestion. It would be nice if the message "Your Marks of Grace are about to despawn!" included the number of marks, like "Your 32 Marks of Grace ..."

There are times (yes already) where I afk too long even after seeing the message (totally my fault), and it would have been nice to know how many marks I lost haha. Could probably just use the same number as whatever "Marks on Ground" is populated from.

Cyborger1 commented 7 hours ago

I already have a plugin hub request for a refactor of this plugin that I'd like to have go through first, but once that's done I'll put a new request for a change that adds (x Marks) at the end of the notification message. I already wrote the change so it shouldn't be too long once the first request is through.

While it doesn't apply in your case, one of the changes from the refactor is being able to notify independently for separate stacks of marks on courses that aren't the Ardougne course, since I'm now keeping track of the last spawn time for each stack.

You should expect to see messages in this format once both changes are through: Your Marks of Grace stack is about to despawn! (5 Marks) One of your Marks of Grace stacks is about to despawn! (1 Mark)