This logic causes clicks. If a new note on comes in while the old note is still in release, then the envelope will suddenly be scaled to a new velocity, causing an audible click. Subtractive synth preset 4 is a great way to hear this. This envelope-scaling logic needs to be baked into the envelope somehow for this to be correct. Just adding a slide~ after the latch~ would get rid of the click but cause a different issue.
This logic causes clicks. If a new note on comes in while the old note is still in release, then the envelope will suddenly be scaled to a new velocity, causing an audible click. Subtractive synth preset 4 is a great way to hear this. This envelope-scaling logic needs to be baked into the envelope somehow for this to be correct. Just adding a slide~ after the latch~ would get rid of the click but cause a different issue.