Add missing macOS header

Cycling74 / max-sdk

Software Development Kit for Max by Cycling '74

Other

262 stars 57 forks source link

Add missing macOS header #39

Closed jcelerier closed 4 years ago

jcelerier commented 4 years ago

Hello, for some reason while updating I'm now missing this header when building externals (clang was complaining about MPCriticalRegionID not being defined).

tap commented 4 years ago

Hi @jcelerier -- If you are able to submit our CLA form (you only need to do this once) then I am happy to merge this PR.

https://cycling74.com/cla

Cheers, ./Tim

jcelerier commented 4 years ago

Sent the CLA form. Thanks !

arvidtp commented 4 years ago

Note: I get build errors after this change on an older external the includes buffer.h. If I change it to include ext_buffer.h instead, it compiles and works.

tap commented 4 years ago

Thanks for reporting this @arvidtp .

Using ext_buffer.h has been preferred for a number of years now. Ideally however, we are not making breaking changes to existing code out there. I'll keep my eyes open for any related reports.